Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it possible to disable the submit workflow on the website #3223

Merged
merged 5 commits into from
Nov 19, 2024
Merged

make it possible to disable the submit workflow on the website #3223

merged 5 commits into from
Nov 19, 2024

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Nov 18, 2024 •
edited
Loading

resolves #3211

preview URL: https://3211-make-it-possible-to.loculus.org/

Summary

Adds 3 new config values in the values.yaml:

website:
  websiteConfig:
    enableLoginNavigationItem: false
    enableSubmissionNavigationItem: false
    enableSubmissionPages: false

Screenshot

Locally, when setting all new config values to false:
grafik

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Nov 18, 2024
@fengelniederhammer fengelniederhammer force-pushed the 3211-make-it-possible-to-disable-the-submit-workflow-on-the-website branch from de8ca2c to 155404d Compare November 18, 2024 14:48
@fengelniederhammer fengelniederhammer force-pushed the 3211-make-it-possible-to-disable-the-submit-workflow-on-the-website branch from a34fbfe to 87f6ce4 Compare November 19, 2024 11:22
chaoran-chen
chaoran-chen approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I just left one question.

@fengelniederhammer fengelniederhammer merged commit a6b3bb7 into main Nov 19, 2024
20 checks passed
@fengelniederhammer fengelniederhammer deleted the 3211-make-it-possible-to-disable-the-submit-workflow-on-the-website branch November 19, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-parker anna-parker anna-parker left review comments

@chaoran-chen chaoran-chen chaoran-chen approved these changes

@fhennig fhennig Awaiting requested review from fhennig

@theosanderson theosanderson Awaiting requested review from theosanderson

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it possible to disable the submit workflow on the website
3 participants
@fengelniederhammer @chaoran-chen @anna-parker