Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backend): fix flaky test that made wrong assumptions about order being guaranteed #3234

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Nov 18, 2024

resolves #3235

Came up frequently while working on #3232 so I decided to fix it (but break out into separate PR to keep that PR clean)

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Co-authored-by: Fabian Engelniederhammer <[email protected]>
@corneliusroemer corneliusroemer merged commit c0959b7 into main Nov 19, 2024
17 checks passed
@corneliusroemer corneliusroemer deleted the fix-test branch November 19, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend related to the loculus backend component review please PR waiting for final review tests Test related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky backend test
2 participants