fix(backend): Fix submitter of revoked sequences to be the revoker #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the revoker Fixes #3244 Update the submitter of a revoked sequence to the revoker * Modify `backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.kt` to set the `submitterColumn` to the revoker's account during the revocation process * Change the `revoke` function to use the revoker's username for the `submitterColumn` instead of cloning the old submitter information --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/loculus-project/loculus/issues/3244?shareId=XXXX-XXXX-XXXX-XXXX).
theosanderson
requested review from
corneliusroemer,
chaoran-chen and
anna-parker
theosanderson
changed the title
|
Thanks! Oof, how did this live so long without us noticing 😬 |
anna-parker
approved these changes
Nov 19, 2024
|
I'm adding a test for this in #3248 |
corneliusroemer
approved these changes
Nov 19, 2024
backend/src/test/kotlin/org/loculus/backend/controller/submission/RevokeEndpointTest.kt
Show resolved
Hide resolved
… errors from happening in future
|
@fengelniederhammer maybe you have some thoughts on how to better test the created sequence entries - we've now got a bunch of helpers, that's not terrible but maybe there's a neater way you know. Also, we might want to test similar basic things explicitly for other parts of the submission flow. |
The helpers already look pretty helpful to me. The tests are nice to read. |
|
@fengelniederhammer I just wasn't sure whether creating a helper for each property was a good way to go. Could come up with a better way (limited Kotlin knowledge). |
|
Let's merge? @theosanderson :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3244
https://theosanderson-fix-revoked.loculus.org/
Update the submitter of a revoked sequence to the revoker
backend/src/main/kotlin/org/loculus/backend/service/submission/SubmissionDatabaseService.ktto set thesubmitterColumnto the revoker's account during the revocation processrevokefunction to use the revoker's username for thesubmitterColumninstead of cloning the old submitter informationTested that autoapprove no longer happens:
For more details, open the Copilot Workspace session.