chore(backend): fix some more racy backend tests by not asserting on exact order #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… independent helper I keep getting some flakes due to exact order requirements in tests. So I've now added a helper that makes it easy to test for accession versions being present in any order. Using this consistently in one test file where I've gotten a few flakes recently, but could probably be rolled out elsewhere as well.
corneliusroemer
added
backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3242
This should avoid most of the flakes due to similar wrongly strong assumptions about SQL result order being stable without explicit sorting.
I can't find any more instances of
jsonPath("\$[*].But I should also look for
jsonPath("\$[0]which I haven't done. Just noticed some tests like this in the revocation tests.