-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): allow dev standin dbs to be semi-persistent through values.yaml #3255
Conversation
(if we do this [which sounds good] we probs want to do it for KC DB too?) |
I was wondering how to name it, it seems a bit much to have booleans but then if we are happy with changing the config setting liberally, especially dev settings I'm happy not to worry too much. Ideally, we'd back these dbs with a persistent volume claim but I don't know enough kubernetes to know how easy or hard that would be. I thought about doing it for keycloak as well, just wanted to test it first for one. |
…ne with main db file name)
The need to do this now arose because I was surprised that virus2's db got replaced after an update, so having the persistence option there through values yaml would be really good. Persistence is a bit of a misnomer as db will get replaced under a few circumstances (eviction, change of kubernetes manifest params etc) but as it's a dev thing I'm not too worried. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
resolves #3254
preview URL: https://persistence.loculus.org
Need to revert from true to false before merging.
Summary
Allows not reloading the main and keycloak dbs for each commit in preview/dev deployments through values.yaml
Note that the database is 20+ minutes old while backend was replaced recently, that's what we can do now:
![image](https://private-user-images.githubusercontent.com/25161793/387857396-5a8a4838-97db-4d88-8f7b-9b741b4209d4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk4MjQ0MzIsIm5iZiI6MTczOTgyNDEzMiwicGF0aCI6Ii8yNTE2MTc5My8zODc4NTczOTYtNWE4YTQ4MzgtOTdkYi00ZDg4LThmN2ItOWI3NDFiNDIwOWQ0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE3VDIwMjg1MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwYzRiMDU5ZDdkM2U2ZjE1YTQ3ZTk5NjVlMjEyYmU0ZDM1NTM2OTk0OGRiMWM1NTA1NGZkY2UwZmE3Yjc0MmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.kDc0AhOyFKEEsoFTjaBOXCSwnLvLDjPbWCrEUnN58K4)