Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow dev standin dbs to be semi-persistent through values.yaml #3255

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Nov 19, 2024

resolves #3254

preview URL: https://persistence.loculus.org

Need to revert from true to false before merging.

Summary

Allows not reloading the main and keycloak dbs for each commit in preview/dev deployments through values.yaml

Note that the database is 20+ minutes old while backend was replaced recently, that's what we can do now:
image

@corneliusroemer corneliusroemer added preview Triggers a deployment to argocd config Configuration related issues, i.e. helm processing labels Nov 19, 2024
@theosanderson
Copy link
Member

(if we do this [which sounds good] we probs want to do it for KC DB too?)

@corneliusroemer
Copy link
Contributor Author

I was wondering how to name it, it seems a bit much to have booleans but then if we are happy with changing the config setting liberally, especially dev settings I'm happy not to worry too much.

Ideally, we'd back these dbs with a persistent volume claim but I don't know enough kubernetes to know how easy or hard that would be.

I thought about doing it for keycloak as well, just wanted to test it first for one.

@corneliusroemer
Copy link
Contributor Author

corneliusroemer commented Nov 19, 2024

The need to do this now arose because I was surprised that virus2's db got replaced after an update, so having the persistence option there through values yaml would be really good.

Persistence is a bit of a misnomer as db will get replaced under a few circumstances (eviction, change of kubernetes manifest params etc) but as it's a dev thing I'm not too worried.

@corneliusroemer corneliusroemer marked this pull request as ready for review November 19, 2024 22:22
@corneliusroemer corneliusroemer changed the title Try dev db persistence through values.yaml feat(config): allow dev standin dbs to be semi-persistent through values.yaml Nov 19, 2024
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration related issues, i.e. helm processing preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow standin database to be made persistent through values.yaml
2 participants