Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade keycloak to v25 #3265

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

chore(deps): upgrade keycloak to v25 #3265

wants to merge 17 commits into from

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Nov 20, 2024

relates to #1221

preview URL: https://test-kc25.loculus.org

Summary

Keycloak 25 works, expect for our custom terms checkbox which doesn't show with our keycloakify theme anymore so we do need to do the keycloakify work. But this is the keycloak part of the task.

This can be bumped to 26, see #3266 without requiring any changes on the keycloak side

Screenshot

image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label Nov 20, 2024
@corneliusroemer corneliusroemer changed the title Don't merge: try out kc upgrade in ci chore(deps): upgrade keycloak to v25 Nov 20, 2024
@fhennig
Copy link
Contributor

fhennig commented Nov 21, 2024

Hey! I had most of these changes locally as well, worked on it yesterday. Everything except for the health endpoint, it was really a mystery to me, good find!

The commandline flags can also be passed as env vars, actually all flags can also be env vars, see docs here.

@corneliusroemer corneliusroemer removed the preview Triggers a deployment to argocd label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants