-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade keycloak to v25 #3265
Draft
corneliusroemer
wants to merge
17
commits into
main
Choose a base branch
from
test-kc25
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+16
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
changed the title
Don't merge: try out kc upgrade in ci
chore(deps): upgrade keycloak to v25
Nov 20, 2024
corneliusroemer
commented
Nov 20, 2024
corneliusroemer
commented
Nov 20, 2024
This reverts commit 907a80a.
…to upgrade keycloakify for it
Hey! I had most of these changes locally as well, worked on it yesterday. Everything except for the health endpoint, it was really a mystery to me, good find! The commandline flags can also be passed as env vars, actually all flags can also be env vars, see docs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1221
preview URL: https://test-kc25.loculus.org
Summary
Keycloak 25 works, expect for our custom terms checkbox which doesn't show with our keycloakify theme anymore so we do need to do the keycloakify work. But this is the keycloak part of the task.
This can be bumped to 26, see #3266 without requiring any changes on the keycloak side
Screenshot
PR Checklist