Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(backend): throw when database clearing fails in tests #3278

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Nov 23, 2024

This would have made it immediately clear what the reason for the test failures in #3259 was. So good to have for future.

Also truncate in one go for simplicity and maybe also performance.

@corneliusroemer corneliusroemer changed the title chore(backend): throw when database clearing fails in tests test(backend): throw when database clearing fails in tests Nov 23, 2024
@corneliusroemer corneliusroemer changed the base branch from main to delete-processed2 November 23, 2024 02:16
This would have made it immediately clear what the reason for the test failures in #3259 was. So good to have for future.

Also truncate in one go for simplicity and maybe also performance.
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chaoran-chen chaoran-chen merged commit 3a876d7 into delete-processed2 Nov 23, 2024
13 checks passed
@chaoran-chen chaoran-chen deleted the test-for-clear-failure branch November 23, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants