Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deposition): Automate metadata revision of ENA submissions #3673

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Feb 11, 2025

resolves #3177

preview URL:

Summary

  1. Refactors code, adding the mapping of loculus fields to the manifest fields into a dictionary in the config for clarity, additionally correcting the mapping of the consensusSequenceSoftware to PROGRAM and sequencingInstrument to PLATFORM.
  2. This enables automatic revision of sequences already submitted to the ENA, it checks for certain edge cases:
  • an older version is added later -> will not revise data
  • a version is uploaded where fields have been revised that end up in the assembly manifest -> biosample will be manually updated and db will be put into state has errors as a manual revision is required for the assembly update.
  • a revision tries to update a biosample or bioproject accession -> this is not allowed and also puts the db into an error state

Screenshot

PR Checklist

  • Ensure bioproject and biosample cannot be revised
  • Test on ENA dev
    • test all current cases still work (with known bioproject, biosample and sra as well)
    • test that if old version is uploaded we error
    • check that sample can be revised
    • check that assembly can be revised
    • check error if changes are in manifest and cannot be automatically revised
  • Create change list and check if changed field is in manifest (must be updated via email).

@anna-parker anna-parker changed the title Allow_revision Automate metadata revision of ENA submissions Feb 11, 2025
@anna-parker anna-parker changed the title Automate metadata revision of ENA submissions feat(deposition): Automate metadata revision of ENA submissions Feb 11, 2025
@anna-parker anna-parker force-pushed the allow_custom_bioproject branch from c69dd6b to 0c198ad Compare February 14, 2025 11:03
Base automatically changed from allow_custom_bioproject to main February 14, 2025 12:33
@anna-parker anna-parker force-pushed the allow_revision branch 2 times, most recently from 47cf50d to 7a87945 Compare February 14, 2025 18:09
@anna-parker anna-parker force-pushed the allow_revision branch 2 times, most recently from fc3bc8b to 0c8774a Compare February 17, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate revising sequence metadata in samples submitted to ENA
1 participant