fix(website)!: use box-content for consistent column widths regardless of position
#3730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
changed the title
border-box for consistent column widths regardless of positionborder-box for consistent column widths regardless of position
theosanderson
changed the title
border-box for consistent column widths regardless of positionbox-content for consistent column widths regardless of position
anna-parker
approved these changes
Feb 24, 2025
|
Ah I think I see it, the last column breaks date into two lines in main but not on preview 😀 |
|
👍 If you open the two links I posted in two tabs and switch between them you should notice the difference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview URL: https://box-content.loculus.org/ebola-sudan/search? vs https://main.loculus.org/ebola-sudan/search?
Summary
We specifically add padding to the last column in the table for aesthetic reasons (
last:pr-6), but this is problematic because we specify widths for each column but those widths include the padding and we don't know which column the user will choose to be last. Here we usebox-contentso that the specified width is just for the content, excluding any padding. This will likely require us to update all widths to take account of this.All columns get a bit bigger on our current previews but I think that's ok as they are not tuned much on Loculus (they are more so on PPX)
Details of breaking changes
We may want to make all specified column widths on PPX 16 pixels narrower to account for the fact that padding is not longer being taken out