Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): add old keycloak flags #3735

Merged
merged 2 commits into from
Feb 25, 2025
Merged

fix(deployment): add old keycloak flags #3735

merged 2 commits into from
Feb 25, 2025

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Feb 24, 2025

resolves #3618 for now

preview URL: https://authentication-kcflags.loculus.org/admin/master/console (admin/admin)

Summary

We upgraded the keycloak environment variable flags without upgrading keycloak itself, meaning an admin account with a known admin password is not created. This is an unfortunate breakage on main for anyone wanting to try out Loculus for their own use, and prevents us logging in ourselves (except on pathoplexus).

Here I add the old flags back as duplicates to mitigate.

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Feb 24, 2025
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry I didn't do this when I realized the bug.

Maybe add an issue to the todo comment or point towards an existing upgrade keycloak one? On mobile right now otherwise I'd do it myself

@corneliusroemer
Copy link
Contributor

Note 2 tests fail and I haven't checked why. They should be checked before merge

@corneliusroemer
Copy link
Contributor

Made issue #3736 to upgrade keycloak, might be good to reference this issue in the code as well :)

@theosanderson theosanderson merged commit 423e897 into main Feb 25, 2025
16 checks passed
@theosanderson theosanderson deleted the kcflags branch February 25, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keycloak previews no longer allow login with admin:admin
2 participants