Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

68 version list and pages #642

Merged
merged 1 commit into from
Dec 13, 2023
Merged

68 version list and pages #642

merged 1 commit into from
Dec 13, 2023

Conversation

TobiasKampmann
Copy link
Contributor

@TobiasKampmann TobiasKampmann commented Dec 8, 2023

merge after #464

@TobiasKampmann TobiasKampmann linked an issue Dec 8, 2023 that may be closed by this pull request
@TobiasKampmann TobiasKampmann added the preview Triggers a deployment to argocd label Dec 8, 2023
@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch 4 times, most recently from e9b711e to cc25c68 Compare December 8, 2023 12:54
@TobiasKampmann TobiasKampmann changed the base branch from main to 464-sequence-page-handle-non-latest-version December 8, 2023 12:59
@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch from cc25c68 to 505637e Compare December 8, 2023 15:44
@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch 2 times, most recently from 37f568e to 71b18e0 Compare December 8, 2023 16:24
@TobiasKampmann TobiasKampmann marked this pull request as ready for review December 8, 2023 16:38
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, just some details. :)

@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch 2 times, most recently from c2e84c8 to 482302e Compare December 11, 2023 13:22
@TobiasKampmann TobiasKampmann force-pushed the 464-sequence-page-handle-non-latest-version branch from 386c30b to 18f2cdd Compare December 11, 2023 14:18
@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch from 1332250 to 84609c6 Compare December 11, 2023 14:30
Base automatically changed from 464-sequence-page-handle-non-latest-version to main December 11, 2023 14:30
@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch 4 times, most recently from e9533bb to 47afd14 Compare December 12, 2023 10:18
@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch from 47afd14 to 2d68c18 Compare December 12, 2023 10:38
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify the overall dataflow a bit (making it easier to understand)

@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch 2 times, most recently from e83955d to eb6c739 Compare December 12, 2023 19:04
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a lot simpler now!

 * parse accessionVersion and redirect to latest version when only accession is given
 * display all versions + silo version status on the versions page
@TobiasKampmann TobiasKampmann force-pushed the 68-version-list-and-pages branch from 8f394fc to db4b19a Compare December 13, 2023 15:56
@TobiasKampmann TobiasKampmann merged commit c55d715 into main Dec 13, 2023
@TobiasKampmann TobiasKampmann deleted the 68-version-list-and-pages branch December 13, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version list and pages
4 participants