-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
68 version list and pages #642
Conversation
e9b711e
to
cc25c68
Compare
cc25c68
to
505637e
Compare
37f568e
to
71b18e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, just some details. :)
website/src/pages/[organism]/sequences/[accessionVersion]/parseAccessionVersionPathVariable.ts
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/index.astro
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/versions.astro
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/versions.astro
Outdated
Show resolved
Hide resolved
c2e84c8
to
482302e
Compare
386c30b
to
18f2cdd
Compare
1332250
to
84609c6
Compare
e9533bb
to
47afd14
Compare
47afd14
to
2d68c18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify the overall dataflow a bit (making it easier to understand)
website/src/components/SequenceDetailsPage/SequenceDetailsErrorType.ts
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/SequenceDetailsPicker.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/SequenceDetailsPicker.tsx
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/versions.astro
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/versions.astro
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/index.astro
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/index.astro
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/versions.astro
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/getSequenceDetailsTableData.ts
Show resolved
Hide resolved
e83955d
to
eb6c739
Compare
website/src/pages/[organism]/sequences/[accessionVersion]/versions.astro
Show resolved
Hide resolved
3163d79
to
90293f8
Compare
90293f8
to
8f394fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and a lot simpler now!
website/src/components/SequenceDetailsPage/SequenceDetailsErrorType.ts
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/SequencesDataTableTitle.astro
Outdated
Show resolved
Hide resolved
website/src/components/SequenceDetailsPage/SequencesDataTableTitle.astro
Outdated
Show resolved
Hide resolved
website/src/pages/[organism]/sequences/[accessionVersion]/versions.astro
Outdated
Show resolved
Hide resolved
* parse accessionVersion and redirect to latest version when only accession is given * display all versions + silo version status on the versions page
8f394fc
to
db4b19a
Compare
merge after #464