Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support translations #53

Closed
becky-gilbert opened this issue Oct 3, 2024 · 0 comments · Fixed by #54, #68 or #95
Closed

Support translations #53

becky-gilbert opened this issue Oct 3, 2024 · 0 comments · Fixed by #54, #68 or #95
Assignees

Comments

@becky-gilbert
Copy link
Contributor

TL;DR

We would like to support translations for CHS plugins with hard-coded/non-parameterized text, such as video-consent and video-config.

Summary

The first iteration of plugins used hard-coded English text, but we would like to allow researchers to select the study language, which should automatically translate all hard-coded text into that language. Ideally we would be able to re-use our EFP yaml translation files with no/minimal changes.

To support translations, we propose building a separate package with a function that can be called with the language, HTML template, and template context/parameters, and return the appropriate HTML-formatted content. By making this a separate package, we can update the translations and increment version numbers separately to the rest of the lookit-jspsych packages.

@becky-gilbert becky-gilbert linked a pull request Oct 3, 2024 that will close this issue
@okaycj okaycj closed this as completed in #54 Oct 9, 2024
@becky-gilbert becky-gilbert linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants