Video consent copy #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5c9bc23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed
okaycj
force-pushed
the
video-consent-copy
branch
from
dcb2242 to
676842d
Compare
* Remove mustache dependency * Remove mustache config * Rename template extensions * Remove mustache code and replace with handlebars * Format changes * Fixed issue with import * changset
* Remove mustache dependency * Remove mustache config * Rename template extensions * Remove mustache code and replace with handlebars * Format changes * Fixed issue with import * Translation files * Support selecting translation from trial parameters * Error when no translation is available. * Tests * Format/YAML fix * Add line wrap to prettier config * changset
becky-gilbert
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Fantastic! A few questions/comments.
- I think we need to add a Video Consent section to the
recordpackage docs (README). Hopefully you can just link to the EFP docs, if all of the parameters are still supported and work the same way. - I realize changesets/versioning doesn't actually matter yet, but just so that we're on the same page with how we want to do it: I think that each changeset file should only list the packages that are affected by the change (feature/fix). So for instance, we'd have one that bumps the
recordpackage with: "Add video consent plugin". And the separate ones for switching to handlebars and adding translations, but again just forrecord? This PR does include changes to other packages, but those changes are just due to prettier line wrapping. So you could add a changeset with all packages for that, but IMO that sort of change doesn't warrant a changeset/version bump since it doesn't affect the code itself.
I'll get the documentation in a separate PR. Thank you. |
becky-gilbert
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves over video consent template five and the english translation file.