Add test #1
Merged
Add test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louix
reviewed
Jan 17, 2024
Comment on lines
+25
to
+28
| const c1 = Skia.Color("cyan"); | ||
| const c2 = Skia.Color([0, 1, 1, 1]); | ||
| const c3 = Skia.Color(0xff00ffff); | ||
| const c4 = Skia.Color(Float32Array.of(0, 1, 1, 1)); |
There was a problem hiding this comment.
Hey, thanks! I should have added these myself.
I assumed from #2113 that number[] expected 0-255 (and so coded it that way on the C++ side). Should I change it to 0-1 to match Float32Array?
There was a problem hiding this comment.
I actually not sure I need to check 🙈 also a good test to add would be to use the drawOffscreen API to make sure they all generate the same image (cyan).
I tried to write more info at https://github.com/Shopify/react-native-skia/pull/2145/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.