forked from Shopify/react-native-skia
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test #1
Merged
Merged
Add test #1
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import { surface } from "../setup"; | ||
|
||
describe("Colors", () => { | ||
it("should support int, string, array, and Float32Array", async () => { | ||
const result = await surface.eval((Skia) => { | ||
const areEqualFloat32Arrays = (...arrays: Float32Array[]) => { | ||
// Check if all arrays have the same length | ||
const allSameLength = arrays.every( | ||
(array) => array.length === arrays[0].length | ||
); | ||
if (!allSameLength) { | ||
return false; | ||
} | ||
|
||
// Compare elements across all arrays for each index | ||
for (let i = 0; i < arrays[0].length; i++) { | ||
if (!arrays.every((array) => array[i] === arrays[0][i])) { | ||
return false; | ||
} | ||
} | ||
|
||
return true; | ||
}; | ||
|
||
const c1 = Skia.Color("cyan"); | ||
const c2 = Skia.Color([0, 1, 1, 1]); | ||
const c3 = Skia.Color(0xff00ffff); | ||
const c4 = Skia.Color(Float32Array.of(0, 1, 1, 1)); | ||
|
||
const r = areEqualFloat32Arrays(c1, c2, c3, c4); | ||
if (!r) { | ||
console.log({ c1, c2, c3, c4 }); | ||
} | ||
return r; | ||
}); | ||
expect(result).toBe(true); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks! I should have added these myself.
I assumed from #2113 that
number[]
expected 0-255 (and so coded it that way on the C++ side). Should I change it to 0-1 to match Float32Array?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually not sure I need to check 🙈 also a good test to add would be to use the drawOffscreen API to make sure they all generate the same image (cyan).
I tried to write more info at https://github.com/Shopify/react-native-skia/pull/2145/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5