Skip to content

Commit

Permalink
Add TODO comments to element_ids field for migration tracking
Browse files Browse the repository at this point in the history
  • Loading branch information
LeonWehrhahn committed Dec 6, 2024
1 parent 87a66a7 commit 3a10e22
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion athena/athena/models/db_modeling_feedback.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
class DBModelingFeedback(DBFeedback, Base):
__tablename__ = "modeling_feedbacks"

element_ids: Optional[list[str]] = Column(JSON) # type: ignore
element_ids: Optional[list[str]] = Column(JSON) # type: ignore Todo: Remove after adding migrations to athena
reference: Optional[str] = Column(String, nullable=True) # type: ignore

exercise_id = Column(BigIntegerWithAutoincrement, ForeignKey("modeling_exercises.id", ondelete="CASCADE"), index=True)
Expand Down
2 changes: 1 addition & 1 deletion athena/athena/schemas/modeling_feedback.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
class ModelingFeedback(Feedback):
"""Feedback on a modeling exercise."""

element_ids: Optional[List[str]] = Field([], description="referenced diagram element IDs", example=["id_1"])
element_ids: Optional[List[str]] = Field([], description="referenced diagram element IDs", example=["id_1"]) # Todo: Remove after adding migrations to athena
reference: Optional[str] = Field(None, description="reference to the diagram element", example="ClassAttribute:5a337bdf-da00-4bd0-a6f0-78ba5b84330e")

0 comments on commit 3a10e22

Please sign in to comment.