Skip to content

Commit

Permalink
revert cmake file + update makefile
Browse files Browse the repository at this point in the history
  • Loading branch information
Vighnesh-V committed Oct 11, 2024
1 parent 5d74685 commit 837bba3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 0 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,6 @@ else()
list(APPEND LUAU_OPTIONS -Wall) # All warnings
list(APPEND LUAU_OPTIONS -Wimplicit-fallthrough)
list(APPEND LUAU_OPTIONS -Wsign-compare) # This looks to be included in -Wall for GCC but not clang
list(APPEND LUAU_OPTIONS -Wno-maybe-uninitialized)

endif()

if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
Expand All @@ -126,8 +124,6 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
# Some gcc versions treat var in `if (type var = val)` as unused
# Some gcc versions treat variables used in constexpr if blocks as unused
list(APPEND LUAU_OPTIONS -Wno-unused)
# GCC has some bugs where we optional<string> is treated as uninitialized if it is on a structg

endif()

# Enabled in CI; we should be warning free on our main compiler versions but don't guarantee being warning free everywhere
Expand Down
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,10 @@ LDFLAGS=

# some gcc versions treat var in `if (type var = val)` as unused
# some gcc versions treat variables used in constexpr if blocks as unused
# some gcc versions warn maybe uninitalized on optional<std::string> members on structs
ifeq ($(findstring g++,$(shell $(CXX) --version)),g++)
CXXFLAGS+=-Wno-unused
CXXFLAGS+=-Wno-maybe-uninitialized
endif

# enabled in CI; we should be warning free on our main compiler versions but don't guarantee being warning free everywhere
Expand Down

0 comments on commit 837bba3

Please sign in to comment.