Create test-specific 🐳 file #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c30c68.
michplunkett
commented
Dec 30, 2023
| COPY package.json /usr/src/app/ | ||
| RUN yarn | ||
|
|
||
| COPY test_data.py /usr/src/app/ | ||
| COPY mypy.ini /usr/src/app/ | ||
| EXPOSE 3000 |
There was a problem hiding this comment.
This line was redundant.
michplunkett
commented
Dec 31, 2023
| on: | ||
| pull_request: | ||
| branches: | ||
| - develop | ||
| - main |
There was a problem hiding this comment.
We have stopped using main, so I removed it from this file.
michplunkett
requested review from
b-meson,
abandoned-prototype and
sea-kelp
4 tasks
b-meson
approved these changes
May 3, 2024
|
Thanks for working on this @michplunkett, feel free to merge it whenever you can. |
|
I'm workin' on some school stuff now, but I'll likely merge it tomorrow when I can make sure everything is 💯 . |
|
I ran everything on my local again, and it looks like we're good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
make test#1054Description of Changes
Creating a test-specific 🐳 Docker file. This will be the first step in implementing PostgreSQL in the testing environment so that we can get a true 1:1 comparison between the environments.
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.