Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change required php version to >=7.2.5 #231

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Change required php version to >=7.2.5 #231

merged 2 commits into from
Sep 30, 2023

Conversation

hristokpopov
Copy link

No description provided.

@goetas
Copy link
Collaborator

goetas commented Sep 30, 2023

can you please run the CI for 7.2.5 and 7.4 php versions?

@hristokpopov
Copy link
Author

can you please run the CI for 7.2.5 and 7.4 php versions?

I have added SF 5.4 run with PHP (7.2.5, 7.4)
SF 6 still runs with PHP (8.1, 8.2)

Is this acceptable?

https://github.com/hristokpopov/LocaleBundle/actions/runs/6361083915/job/17275271178?pr=2

@goetas goetas merged commit 958ee25 into lunetics-org:3.x Sep 30, 2023
8 checks passed
@goetas
Copy link
Collaborator

goetas commented Sep 30, 2023

thanks

@hristokpopov
Copy link
Author

Thanks for the assistance and prompt responses

@hristokpopov hristokpopov mentioned this pull request Sep 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hristokpopov @goetas