Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SQDSDKS-5723 - Remove custom attributes limit to MPEvents. #456

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat: SQDSDKS-5723 - Remove custom attributes limit to MPEvents. #456

merged 2 commits into from
Dec 13, 2023

Conversation

markvdouw
Copy link

No need to remove user attribute limit since it wasn't implemented. Other limits (key and value length for user and custom attributes) remaing the same.

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Removing custom attributes limit

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Remove custom attributes limit to MPEvents.
6bc0120 
No need to remove user attribute limit since it wasn't implemented.
Other limits (key and value length for user and custom attributes) remaing the same.
@markvdouw markvdouw marked this pull request as ready for review November 29, 2023 16:35
Update cross-platform-tests.yml
c4b5710 
Updaing script

Signed-off-by: markvdouw <[email protected]>
@markvdouw markvdouw merged commit a533731 into development Dec 13, 2023
22 of 23 checks passed
@markvdouw markvdouw deleted the feat/SQDSDKS-5723_remove_custom_attributes_limit branch December 13, 2023 14:36
einsteinx2 pushed a commit that referenced this pull request Dec 13, 2023
@einsteinx2
feat: SQDSDKS-5723 - Remove custom attributes limit to MPEvents. (#456)
32c788e 
* Remove custom attributes limit to MPEvents.
No need to remove user attribute limit since it wasn't implemented.
Other limits (key and value length for user and custom attributes) remaing the same.

* Update cross-platform-tests.yml

Updaing script

Signed-off-by: markvdouw <[email protected]>

---------

Signed-off-by: markvdouw <[email protected]>
mparticle-automation added a commit that referenced this pull request Dec 13, 2023
@mparticle-automation
chore: 5.55.0 (release)
c7287b6 
## [5.55.0](v5.54.0...v5.55.0) (2023-12-13)

### Features

* SQDSDKS-5723 - Remove custom attributes limit to MPEvents. ([#456](#456)) ([32c788e](32c788e))

### Bug Fixes

* only delete branch if all succeeds ([f239ba8](f239ba8))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdozor samdozor samdozor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markvdouw @samdozor