Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SQDSDKS-5723 - Remove custom attributes limit to MPEvents. #456

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat: SQDSDKS-5723 - Remove custom attributes limit to MPEvents. #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bc0120
Remove custom attributes limit to MPEvents.
Nov 29, 2023
c4b5710
Update cross-platform-tests.yml
Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion .github/workflows/cross-platform-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,48 @@ jobs:
uses: actions/checkout@v3
with:
repository: mParticle/crossplatform-sdk-tests

- name: "Checkout Android SDK Branch"
uses: actions/checkout@v3
with:
repository: ${{github.event.pull_request.head.repo.full_name}}
ref: ${{github.head_ref}}
path: .sdks/android

- name: Gradle cache
uses: gradle/gradle-build-action@842c587ad8aa4c68eeba24c396e15af4c2e9f30a #v2.9.0

- name: AVD cache
uses: actions/cache@v3
id: avd-cache
with:
path: |
~/.android/avd/*
~/.android/adb*
key: avd-cache

- name: create AVD and generate snapshot for caching
if: steps.avd-cache.outputs.cache-hit != 'true'
uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b #v2.28.0
with:
api-level: 29
force-avd-creation: false
emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
disable-animations: false
script: echo "Generated AVD snapshot for caching."

- name: "Install JDK 11"
uses: actions/setup-java@v3
with:
distribution: "zulu"
java-version: "11"
- name: "Run Crossplatform Tests"
uses: reactivecircus/android-emulator-runner@b35b1c6e6921ebfd3f980c2236ac298f019df53a #v2.28.0
uses: reactivecircus/android-emulator-runner@d94c3fbe4fe6a29e4a5ba47c12fb47677c73656b #v2.28.0
with:
api-level: 29
force-avd-creation: false
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
disable-animations: true
script: ./gradlew runAndroid
- name: "Archive Test Results"
if: ${{ always() }}
Expand Down
1 change: 0 additions & 1 deletion android-core/src/main/java/com/mparticle/internal/Constants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ public static void setMaxMessagePerBatch(int max) {
// preferences persistence
public static final String PREFS_FILE = "mParticlePrefs";

public static final int LIMIT_ATTR_COUNT = 100;
public static final int LIMIT_ATTR_KEY = 256;
public static final int LIMIT_ATTR_VALUE = 4096;
public static final int LIMIT_MAX_MESSAGE_SIZE = 100 * 1024;
Expand Down
5 changes: 0 additions & 5 deletions android-core/src/main/java/com/mparticle/internal/MPUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,11 +719,6 @@ public static Boolean setCheckedAttribute(JSONObject attributes, String key, Obj
if (caseInsensitive) {
key = findCaseInsensitiveKey(attributes, key);
}

if (Constants.LIMIT_ATTR_COUNT == attributes.length() && !attributes.has(key)) {
Logger.error("Attribute count exceeds limit. Discarding attribute: " + key);
return false;
}
if (value != null) {
String stringValue = value.toString();
if (stringValue.length() > Constants.LIMIT_ATTR_VALUE) {
Expand Down
Loading