refactor: Migrate Internal Constants class to kotlin #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
requested changes
Oct 1, 2024
rmi22186
approved these changes
Oct 1, 2024
einsteinx2
requested changes
Oct 2, 2024
|
|
||
| class BatchId { | ||
| var mpid: Long | ||
| get() = field |
There was a problem hiding this comment.
These get() methods should be able to be removed as well since they just return the value which the automatic getter will already do.
|
Everything else looks good to go |
einsteinx2
requested changes
Oct 2, 2024
Comment on lines
7
to
9
| var sessionId: String? | ||
| var dataplanId: String? | ||
| var dataplanVersion: Int? |
There was a problem hiding this comment.
Suggested change
| var sessionId: String? | |
| var dataplanId: String? | |
| var dataplanVersion: Int? | |
| val sessionId: String? | |
| val dataplanId: String? | |
| val dataplanVersion: Int? |
All of these should be val unless we need to set them after object instantiation, val should work fine with optionals as long as they're all set in all constructors (even if set to null).
einsteinx2
approved these changes
Oct 2, 2024
mparticle-automation
added a commit
that referenced
this pull request
Oct 15, 2024
## [5.58.3](v5.58.2...v5.58.3) (2024-10-15) ### Updates & Maintenance * Migrate Internal Constants class to kotlin ([#510](#510)) ([2fd32f6](2fd32f6)) * Migrate MPLifecycleCallbackDelegate and MPLocationListener class to Kotlin ([#506](#506)) ([687e623](687e623)) * Remove unused session history upload code ([#507](#507)) ([a86cd3b](a86cd3b)) * Update submodules ([c0ffeb6](c0ffeb6))
|
🎉 This PR is included in version 5.58.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
mparticle-automation
added a commit
that referenced
this pull request
Oct 24, 2024
## [5.58.3](v5.58.2...v5.58.3) (2024-10-24) ### Updates & Maintenance * Migrate Internal Constants class to kotlin ([#510](#510)) ([2fd32f6](2fd32f6)) * Migrate MPLifecycleCallbackDelegate and MPLocationListener class to Kotlin ([#506](#506)) ([687e623](687e623)) * Remove unused session history upload code ([#507](#507)) ([a86cd3b](a86cd3b)) * Update submodules ([81e50ca](81e50ca))
|
🎉 This PR is included in version 5.58.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)