Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate Internal Constants class to kotlin #510

Merged
merged 10 commits into from
Oct 3, 2024
Merged

refactor: Migrate Internal Constants class to kotlin #510

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a4cd58
refactor: Migrate Internal Constants class to kotlin
Mansi-mParticle Sep 26, 2024
66e4078
Fix lint error
Mansi-mParticle Sep 26, 2024
5843a1a
fix kitcompatibiliity test
Mansi-mParticle Sep 26, 2024
c2cde4d
IntegrationAttributes make optional
Mansi-mParticle Sep 26, 2024
94f1dbb
fix crossplatform test cases
Mansi-mParticle Sep 27, 2024
e6dc627
Rollback CoreCallbacks class
Mansi-mParticle Sep 27, 2024
61e2ead
Add a reference link for additional context
Mansi-mParticle Oct 1, 2024
9559fca
Address review comments
Mansi-mParticle Oct 2, 2024
9e1b709
Revert code
Mansi-mParticle Oct 2, 2024
905ed54
change var to val
Mansi-mParticle Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android-core/src/main/java/com/mparticle/identity/IdentityApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public MParticleUser getCurrentUser() {
*/
@Nullable
public MParticleUser getUser(@NonNull Long mpid) {
if (!Constants.TEMPORARY_MPID.equals(mpid) && mConfigManager.mpidExists(mpid)) {
if (Constants.TEMPORARY_MPID != mpid && mConfigManager.mpidExists(mpid)) {
rmi22186 marked this conversation as resolved.
Show resolved Hide resolved
return MParticleUserImpl.getInstance(mContext, mpid, mUserDelegate);
} else {
return null;
Expand Down Expand Up @@ -252,7 +252,7 @@ public BaseIdentityTask modify(@NonNull final IdentityApiRequest updateRequest)
if (updateRequest.mpid == null) {
updateRequest.mpid = mConfigManager.getMpid();
}
if (Constants.TEMPORARY_MPID.equals(updateRequest.mpid)) {
if (Constants.TEMPORARY_MPID == updateRequest.mpid) {
rmi22186 marked this conversation as resolved.
Show resolved Hide resolved
String message = "modify() requires a non-zero MPID, please make sure a MParticleUser is present before making a modify request.";
if (devMode) {
throw new IllegalArgumentException(message);
Expand Down
67 changes: 0 additions & 67 deletions android-core/src/main/java/com/mparticle/internal/BatchId.java
View file
Open in desktop

This file was deleted.

Loading
Loading