Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-1449 Import wallet flow #1179

Merged
merged 13 commits into from
Sep 5, 2024
Merged

TW-1449 Import wallet flow #1179

merged 13 commits into from
Sep 5, 2024

Conversation

keshan3262
Copy link
Collaborator

No description provided.

@keshan3262 keshan3262 added the EVM label Aug 6, 2024
@keshan3262 keshan3262 marked this pull request as ready for review August 26, 2024 13:21
alex-tsx
alex-tsx reviewed Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@alex-tsx alex-tsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

webpack/manifest.ts Outdated Show resolved Hide resolved
src/app/templates/ImportAccountModal/selectors.ts Outdated Show resolved Hide resolved
src/app/templates/SeedPhraseInput/index.tsx Outdated Show resolved Hide resolved
src/app/templates/SeedPhraseInput/index.tsx Outdated Show resolved Hide resolved
src/app/atoms/FormField.tsx Outdated Show resolved Hide resolved
src/app/templates/SeedPhraseInput/SeedLengthSelect/SeedLengthSelect.tsx Show resolved Hide resolved
src/app/templates/ImportAccountModal/forms/watch-only.tsx Outdated Show resolved Hide resolved
src/app/templates/ImportAccountModal/index.tsx Outdated Show resolved Hide resolved
@keshan3262 keshan3262 requested a review from lendihop September 2, 2024 13:26
alex-tsx
alex-tsx reviewed Sep 2, 2024
View reviewed changes
webpack/manifest.ts
@@ -70,6 +70,7 @@ const buildManifestV3 = (vendor: string): Manifest.WebExtensionManifest => {

permissions: PERMISSIONS,
host_permissions: HOST_PERMISSIONS,
optional_permissions: ['clipboardRead'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it for V3 then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that yes, see https://developer.chrome.com/docs/extensions/reference/api/permissions#step_2_declare_optional_permissions_in_the_manifest

src/app/templates/SeedPhraseInput/index.tsx Outdated Show resolved Hide resolved
src/app/templates/SeedPhraseInput/index.tsx Outdated Show resolved Hide resolved
src/lib/browser/info.ts Outdated Show resolved Hide resolved
@keshan3262 keshan3262 requested a review from lendihop September 3, 2024 10:28
IrynaKhyzhynska
IrynaKhyzhynska approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@IrynaKhyzhynska IrynaKhyzhynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firefox done

tttt24
tttt24 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@tttt24 tttt24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@alex-tsx alex-tsx merged commit 106603b into TW-1446-epic-evm-account-management Sep 5, 2024
2 checks passed
This was referenced Nov 12, 2024
Draft
Draft
@alex-tsx alex-tsx mentioned this pull request Nov 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tttt24 tttt24 tttt24 approved these changes

@alex-tsx alex-tsx alex-tsx approved these changes

@lendihop lendihop lendihop approved these changes

@IrynaKhyzhynska IrynaKhyzhynska IrynaKhyzhynska approved these changes

Assignees

@keshan3262 keshan3262

Labels
EVM qa approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keshan3262 @IrynaKhyzhynska @lendihop @alex-tsx @tttt24