Move clocks configuration to DT #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align UARTE driver config to nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
SYSTEM_CLOCK_WAIT will be a common part for a next version of Nordic timer. Signed-off-by: Witold Lukasik <[email protected]>
NRF_RTC_TIMER will not be a default timer in the next version of Nordic timer. It should be soc selection specific. Signed-off-by: Witold Lukasik <[email protected]>
Add dts bindings for Global Real-Time Counter. Signed-off-by: Magdalena Pastula <[email protected]>
Add GRTC instance in Nordic HAL configs. Signed-off-by: Magdalena Pastula <[email protected]>
Add GRTC as possible clock source. Signed-off-by: Magdalena Pastula <[email protected]>
Add Nordic driver for GRTC. Signed-off-by: Magdalena Pastula <[email protected]>
Add new TIMER instances for nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
Add new TIMER instances for nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
Add new UARTE instances for nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
Add new UARTE instances for nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
Add address validation for new WDT instances on nRF54L15. Signed-off-by: Witold Lukasik <[email protected]>
Add dts files for nRF54L15 chip. Signed-off-by: Witold Lukasik <[email protected]>
RRAM is a part of nRF54L15 SOC. Signed-off-by: Witold Lukasik <[email protected]>
Add soc files for new Nordic family. Signed-off-by: Witold Lukasik <[email protected]>
Add config files for nRF54L15. Signed-off-by: Witold Lukasik <[email protected]>
Add board files for nRF54L15 DK. Signed-off-by: Witold Lukasik <[email protected]>
Add Nordic driver for cache. Signed-off-by: Witold Lukasik <[email protected]>
Add support for new Nordic family in west commands. Signed-off-by: Witold Lukasik <[email protected]>
Add overlay file for counter_basic_api test. Signed-off-by: Witold Lukasik <[email protected]>
Chaged _ISR_OFFSET to be 28 as specified in OPS. Added nrfx_uarte_20_irq_handler as CONSOLE_UART_IRQ_HANDLER. Signed-off-by: Witold Lukasik <[email protected]>
Add overlay files to uart tests for nRF54L15. Signed-off-by: Witold Lukasik <[email protected]>
Add overlay file for gpio_basic_api test. Signed-off-by: Magdalena Pastula <[email protected]>
Add overlay files for i2s tests. Signed-off-by: Magdalena Pastula <[email protected]>
Add overlay file to spi_loopback test for nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
Add overlay file for wdt_basic_api test. Signed-off-by: Magdalena Pastula <[email protected]>
Add overlay file for qdec test. Signed-off-by: Magdalena Pastula <[email protected]>
Add overlay file for watchdog sample. Signed-off-by: Magdalena Pastula <[email protected]>
Update hwinfo driver to be aligned to nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
In nRF54L15 FICR can be accessed also from non-secure code, so it does not have NRF_FICR_S defined. Signed-off-by: Magdalena Pastula <[email protected]>
To describe the low frequency crystal oscillator present in some nRF series. Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
force-pushed
the
upstream-nrf54l15
branch
from
bdf34d7
to
3eda10a
Compare
masz-nordic
reviewed
Jan 19, 2024
| include: [fixed-clock.yaml] | ||
|
|
||
| properties: | ||
| clock-frequency: |
There was a problem hiding this comment.
How about crystal-frequency? So it's not confused with frequencies generated by CLOCK.
There was a problem hiding this comment.
It's a property inherited from fixed-clock, and specified the frequency of the clock itself (not of any other generated clock using this one as a source). I'd align with others using fixed-clock (a similar case is STM32 HSE)
nordicjm
reviewed
Jan 19, 2024
| lfxo: lfxo { | ||
| compatible = "nordic,nrf-lfxo"; | ||
| #clock-cells = <0>; | ||
| clock-frequency = <32768>; |
There was a problem hiding this comment.
Isn't this superfluous since
clock-frequency:
const: 32768
?
There was a problem hiding this comment.
it's still required
devicetree error: 'clock-frequency' is marked as required in 'properties:' in /home/gmarull/ws/nordic/zephyrproject/zephyr/dts/bindings/clock/nordic,nrf-lfxo.yaml, but does not appear in <Node /clocks/lfxo in '/home/gmarull/ws/nordic/zephyrproject/zephyr/misc/empty_file.c'>
There was a problem hiding this comment.
# 'const' is just a special case of an enum with a single possible value I had no idea, the more you know
| hfxo: hfxo { | ||
| compatible = "nordic,nrf-hfxo"; | ||
| #clock-cells = <0>; | ||
| clock-frequency = <32000000>; |
Add LFXO clock node. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Configure LFXO to use internal capacitors with 15.5pF. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Instead of relying on Kconfig options. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Add bindings for the nRF HFXO present in some nRF SoCs. Signed-off-by: Gerard Marull-Paretas <[email protected]>
For HFXO. Signed-off-by: Gerard Marull-Paretas <[email protected]>
To use internal capacitors, with 15pF value. Signed-off-by: Gerard Marull-Paretas <[email protected]>
Instead of Kconfig Signed-off-by: Gerard Marull-Paretas <[email protected]>
gmarull
force-pushed
the
upstream-nrf54l15
branch
from
3eda10a
to
0f3b79f
Compare
magp-nordic
force-pushed
the
upstream-nrf54l15
branch
3 times, most recently
from
716e8b7
to
8bb464f
Compare
|
These changes are now integrated in zephyrproject-rtos#67446 . If you have any notes, please comment there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.