Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: issue detail refactor #6768

Closed
wants to merge 4 commits into from
Closed

chore: issue detail refactor #6768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2648f4
chore: issue detail refactor
vamsikrishnamathala Mar 18, 2025
a622697
chore: added generator for swr key
vamsikrishnamathala Mar 24, 2025
64d883d
chore:added type to swr key constants
vamsikrishnamathala Mar 24, 2025
85e639f
chore: initialize SWR keys configuration structure
vamsikrishnamathala Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore:added type to swr key constants
  • Loading branch information
@vamsikrishnamathala
vamsikrishnamathala committed Mar 24, 2025
commit 64d883d6f13b53ff12028c34ef478fd26b28eca9
2 changes: 2 additions & 0 deletions packages/constants/src/swr-keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
export enum SWR_KEYS {}

export type TSWRKey = SWR_KEYS;
4 changes: 2 additions & 2 deletions packages/utils/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { clsx, type ClassValue } from "clsx";
import { twMerge } from "tailwind-merge";
import { SWR_KEYS } from "@plane/constants";
import { TSWRKey } from "@plane/constants";
// Support email can be configured by the application
export const getSupportEmail = (defaultEmail: string = ""): string => defaultEmail;

Expand Down Expand Up @@ -47,7 +47,7 @@ export const partitionValidIds = (ids: string[], validIds: string[]): { valid: s
* @param params - The parameters for the cache key
* @returns The unique key in array format
*/
export const getSwrKey = (workspaceSlug: string, label: SWR_KEYS, params: string[] = []) => [
export const getSwrKey = (workspaceSlug: string, label: TSWRKey, params: string[] = []) => [
label,
workspaceSlug,
...params,
Expand Down