Custom Prompts Example Config, Docs #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… map default to all .md files. Adds instructions on what the example config files are and how to use them. Removes old default custom prompt from README.
…missing from _config.yaml, rather than resolving to 'default'
… prompts docs to indicate that config should be put in the 'ci' folder.
vincerubinetti
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR used to include example config, but that config will be included in rootstock; see PR manubot/rootstock#512.
This PR is required to merge manubot/rootstock#511, as it includes the documentation that that PR references.
This PR now mostly addresses changes from #43, i.e. updating the docs to reflect that the config files are now in
cirather thancontent, and that the config filenames now just include hyphens, not a mix of hyphens and underscores.Other changes:
files.default_promptvalue would always resort to returning"default"rather than returningNone. With this change, it's now possible to bypass the custom prompts system when no explicit filename matches are found, allowing default prompt resolution to take place.README.md, as it's now provided in the example config rather than hardcoded, and will later be provided in a defaultai-revision-prompts.yamlfile in manubot/rootstock.