-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ontoportal mapping model json converter #281
Add the ontoportal mapping model json converter #281
Conversation
@syphax-bouazzouni thank you for your contribution! This is great and eyeballing what you have done so far, it looks good. I will provide you with a more detailed review later, but in the meantime, we are in general very keen on the |
@syphax-bouazzouni , I just received a review request from you. I seemed to have asked a few questions in August (above) and have not received a response. Could you please kindly address them. |
hello @hrshdhgd, I think I responded to them, can you recheck please |
Really sorry I forgot to submit my reviews (community/community#10369) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matentzn looks good to me. I'll let you look at this before merging.
Not a problem! Thanks for the PR and the clarification. |
I see that QC check fails but it is an easy fix: Run
in your command line and that should fix some errors and show errors that need addressing. This basically formats your code and applies flake8 rules. |
Hi, I did the linting and fixed one of my failing tests. All tests passed now (the 63 ones) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @syphax-bouazzouni !! We really appreciate it!
About
related agroportal/project-management#265
How to use