Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ontoportal mapping model json converter #281

Merged

Conversation

syphax-bouazzouni
Copy link
Contributor

@syphax-bouazzouni syphax-bouazzouni commented Jul 4, 2022

About

related agroportal/project-management#265

How to use

 python -m sssom convert  basic.tsv -o basic-ontoportal.json -O ontoportal_json

@matentzn
Copy link
Collaborator

matentzn commented Jul 5, 2022

@syphax-bouazzouni thank you for your contribution! This is great and eyeballing what you have done so far, it looks good. I will provide you with a more detailed review later, but in the meantime, we are in general very keen on the parsers, not as much the writers - the idea being that we can use SSSOM as a universal exchange format, and sssom-py enabling tools to access resources in different formats. Would you be able to provide us with parser and extension of the sssom parse method as well?

@syphax-bouazzouni syphax-bouazzouni marked this pull request as ready for review July 22, 2022 07:41
@matentzn matentzn requested a review from hrshdhgd August 4, 2022 16:48
@hrshdhgd
Copy link
Contributor

@syphax-bouazzouni , I just received a review request from you. I seemed to have asked a few questions in August (above) and have not received a response. Could you please kindly address them.

@syphax-bouazzouni
Copy link
Contributor Author

hello @hrshdhgd, I think I responded to them, can you recheck please

@syphax-bouazzouni
Copy link
Contributor Author

hello @hrshdhgd, I think I responded to them, can you recheck please

Really sorry I forgot to submit my reviews (community/community#10369)

hrshdhgd
hrshdhgd previously approved these changes Mar 20, 2023
Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matentzn looks good to me. I'll let you look at this before merging.

@hrshdhgd
Copy link
Contributor

hrshdhgd commented Mar 20, 2023

hello @hrshdhgd, I think I responded to them, can you recheck please

Really sorry I forgot to submit my reviews (community/community#10369)

Not a problem! Thanks for the PR and the clarification.

@hrshdhgd
Copy link
Contributor

I see that QC check fails but it is an easy fix:

Run

  • tox -e lint
  • tox -e flake8

in your command line and that should fix some errors and show errors that need addressing. This basically formats your code and applies flake8 rules.

@syphax-bouazzouni
Copy link
Contributor Author

I see that QC check fails but it is an easy fix:

Run

  • tox -e lint
  • tox -e flake8

in your command line and that should fix some errors and show errors that need addressing. This basically formats your code and applies flake8 rules.

Hi, I did the linting and fixed one of my failing tests. All tests passed now (the 63 ones)

Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @syphax-bouazzouni !! We really appreciate it!

@hrshdhgd hrshdhgd merged commit cc22dab into mapping-commons:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants