Test(py-genres-and-actors) #529
Conversation
main.py
Outdated
| Genre.objects.create(name="Western"), | ||
| Genre.objects.create(name="Actions"), | ||
| Genre.objects.create(name="Dramma"), | ||
| Actor.objects.create(first_name="George", last_name="Klooney"), | ||
| Actor.objects.create(first_name="Kianu", last_name="Reaves"), | ||
| Actor.objects.create(first_name="Scarlett", last_name="Keegan"), | ||
| Actor.objects.create(first_name="Will", last_name="Smith"), | ||
| Actor.objects.create(first_name="Scarlett", last_name="Johansson") |
There was a problem hiding this comment.
Consider using a for loop to create multiple objects to avoid redundancy
db/models.py
Outdated
|
|
||
|
|
||
| class Actor(models.Model): | ||
| first_name = models.CharField(max_length=255), |
There was a problem hiding this comment.
Why do you need , in the end?
main.py
Outdated
| create_actors = [ | ||
| {"first_name": "George", "last_name": "Klooney"}, | ||
| {"first_name": "Kianu", "last_name": "Reaves"}, | ||
| {"first_name": "Scarlett", "last_name": "Keegan"}, | ||
| {"first_name": "Will", "last_name": "Smith"}, | ||
| {"first_name": "Jaden", "last_name": "Smith"}, | ||
| {"first_name": "Scarlett", "last_name": "Johansson"} | ||
| ] |
There was a problem hiding this comment.
you can create tuple and use unpacking in for loop
main.py
Outdated
| for actor_data in update_actors: | ||
| filter_fields = { | ||
| key: value for key, value in actor_data.items() if | ||
| not key.startswith("new_") |
main.py
Outdated
|
|
||
| Actor.objects.filter(**filter_fields).update(**update_fields) | ||
|
|
||
| delete_genres = ["Action"] |
There was a problem hiding this comment.
why do you need create variable. You can make it directly
…elete_genres" variable
main.py
Outdated
| update_genres = {"Dramma": "Drama"} | ||
| for old_name, new_name in update_genres.items(): | ||
| Genre.objects.filter(name=old_name).update(name=new_name) |
There was a problem hiding this comment.
There is no need to create an update_genres variable, pass required values directly.
main.py
Outdated
| Actor.objects.filter( | ||
| last_name="Klooney" | ||
| ).update( | ||
| last_name="Clooney" | ||
| ) | ||
|
|
||
| Actor.objects.filter( | ||
| first_name="Kianu", last_name="Reaves" | ||
| ).update( | ||
| first_name="Keanu", last_name="Reeves" | ||
| ) | ||
|
|
||
| Genre.objects.filter(name="Action").delete() |
There was a problem hiding this comment.
There is no need to perform these operations inside of the for loop.
main.py
Outdated
|
|
||
| Genre.objects.filter(name="Action").delete() | ||
|
|
||
| delete_actors = {"first_name": "Scarlett"} |
There was a problem hiding this comment.
There is no need to create a delete_actors variable, pass required values directly.
main.py
Outdated
| last_name_is_smith = Actor.objects.filter( | ||
| last_name="Smith").order_by("first_name") |
There was a problem hiding this comment.
Improve your line breaking so that ).order_by("first_name") would start from a new line.
main.py
Outdated
| for old_name, new_name in {"Dramma": "Drama"}.items(): | ||
| Genre.objects.filter(name=old_name).update(name=new_name) |
There was a problem hiding this comment.
There is no need to make a for loop here, pass "Dramma" and "Drama" directly to the name key.
No description provided.