Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test(py-genres-and-actors) #529

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions db/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Generated by Django 4.0.2 on 2023-10-07 13:48

from django.db import migrations, models


class Migration(migrations.Migration):
initial = True

dependencies = [
]

operations = [
migrations.CreateModel(
name='Actor',
fields=[
('id', models.AutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name='ID')),
('first_name', models.CharField(max_length=255)),
('last_name', models.CharField(max_length=255)),
],
),
migrations.CreateModel(
name='Genre',
fields=[
('id', models.AutoField(
auto_created=True,
primary_key=True,
serialize=False,
verbose_name='ID'
)),
('name', models.CharField(max_length=255)),
],
),
]
9 changes: 9 additions & 0 deletions db/models.py
Original file line number Diff line number Diff line change
@@ -1 +1,10 @@
from django.db import models


class Genre(models.Model):
name = models.CharField(max_length=255)


class Actor(models.Model):
first_name = models.CharField(max_length=255),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need , in the end?

last_name = models.CharField(max_length=255)
23 changes: 21 additions & 2 deletions main.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,26 @@
import init_django_orm # noqa: F401

from db.models import Genre, Actor
from django.db.models import QuerySet


def main() -> QuerySet:
pass
Genre.objects.create(name="Western"),
Genre.objects.create(name="Actions"),
Genre.objects.create(name="Dramma"),
Actor.objects.create(first_name="George", last_name="Klooney"),
Actor.objects.create(first_name="Kianu", last_name="Reaves"),
Actor.objects.create(first_name="Scarlett", last_name="Keegan"),
Actor.objects.create(first_name="Will", last_name="Smith"),
Actor.objects.create(first_name="Scarlett", last_name="Johansson")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a for loop to create multiple objects to avoid redundancy


Genre.objects.filter(name="Dramma").update(name="Drama"),
Actor.objects.filter(last_name="Klooney").update(name="Clooney"),
Actor.objects.filter(first_name="Kianu").update(first_name="Keanu"),
Actor.objects.filter(last_name="Reaves").update(last_name="Reeves")

Genre.objects.filter(name="Drama").delete()
Actor.objects.filter(first_name="Scarlett").delete()

last_name_is_smith = Actor.objects.filter(
last_name="Smith").order_by("first_name")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve your line breaking so that ).order_by("first_name") would start from a new line.

return last_name_is_smith