'Solution' #1431
'Solution' #1431
Conversation
There was a problem hiding this comment.
Great job on implementing the class hierarchy and meeting the task requirements! 🎉 While there are a couple of minor issues, such as the __str__ method being a class method and the alive list being shared among all instances, these do not critically impact the functionality. Consider addressing these for improved code quality. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @classmethod | ||
| def __str__(cls) -> str: |
There was a problem hiding this comment.
The __str__ method should not be a class method. It is typically an instance method that returns a string representation of an instance. Consider removing the @classmethod decorator and adjusting the method to return a string representation of an instance, not the class.
| @@ -2,0 +1,38 @@ | |||
| class Animal: | |||
| alive = [] | |||
There was a problem hiding this comment.
The alive list is a class variable, meaning it is shared among all instances of Animal. If the intention is to track all living animals, this is correct. However, if each instance should have its own alive list, consider making it an instance variable instead.
No description provided.