Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,38 @@
# write your code here
class Animal:
alive = []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alive list is a class variable, meaning it is shared among all instances of Animal. If the intention is to track all living animals, this is correct. However, if each instance should have its own alive list, consider making it an instance variable instead.

def __init__(self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:
self.health = health
self.name = name
self.hidden = hidden
Animal.alive.append(self)

def die(self) -> None:
if self.health <= 0 and self in Animal.alive:
Animal.alive.remove(self)

def __repr__(self) -> str:
return "{{Name: {}, Health: {}, Hidden: {}}}".format(
self.name, self.health, self.hidden
)

@classmethod
def __str__(cls) -> str:
return str(cls.alive)
Comment on lines +23 to +24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __str__ method should not be a class method. It is typically an instance method that returns a string representation of an instance. Consider removing the @classmethod decorator and adjusting the method to return a string representation of an instance, not the class.



class Herbivore(Animal):
def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
def bite(self, animal: Herbivore) -> None:
if isinstance(animal, Herbivore) and not animal.hidden:
animal.health -= 50
if animal.health <= 0:
animal.die()
Loading