Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #664

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

'Solution' #664

wants to merge 2 commits into from

Conversation

TROTPOL
Copy link

@TROTPOL TROTPOL commented Sep 12, 2023

No description provided.

app/main.py Outdated
@staticmethod
def bite(animal: Animal) -> None:
if not isinstance(animal, Carnivore):
if animal.hidden is False:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if animal.hidden is False:
if not isinstance(animal, Carnivore) and not animal.hidden:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can simplify nested if statements using and

@TROTPOL TROTPOL requested a review from pavlejviki September 12, 2023 12:08
Copy link

@pavlejviki pavlejviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants