Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #664

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,36 @@
# write your code here
class Animal:
alive = []

def __init__(
self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:
self.health = health
self.name = name
self.hidden = hidden
Animal.alive.append(self)

def __repr__(self) -> str:
return (
f"{{Name: {self.name}, "
f"Health: {self.health}, "
f"Hidden: {self.hidden}}}"
)


class Herbivore(Animal):

def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):
@staticmethod
def bite(animal: Animal) -> None:
if not isinstance(animal, Carnivore):
if animal.hidden is False:
animal.health -= 50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if animal.hidden is False:
if not isinstance(animal, Carnivore) and not animal.hidden:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can simplify nested if statements using and

if animal.health < 1:
Animal.alive.remove(animal)
Loading