implemented py-herbivores-and-carnivores task #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bohdan-Salamakha
suggested changes
Sep 15, 2023
app/main.py
Outdated
Comment on lines
30
to
32
| not isinstance(herbivore, Carnivore) | ||
| and not herbivore.hidden | ||
| and self.health > 0 |
There was a problem hiding this comment.
animal with the health lower than zero will be automatically removed and the Carnivore will not be able to bite it
Suggested change
| not isinstance(herbivore, Carnivore) | |
| and not herbivore.hidden | |
| and self.health > 0 | |
| not isinstance(herbivore, Carnivore) | |
| and not herbivore.hidden |
app/main.py
Outdated
Comment on lines
35
to
38
| if herbivore.health <= 0: | ||
| herbivore.health = 0 | ||
| Animal.alive.remove(herbivore) | ||
| del herbivore |
There was a problem hiding this comment.
dead animal doesn't need health attr
Suggested change
| if herbivore.health <= 0: | |
| herbivore.health = 0 | |
| Animal.alive.remove(herbivore) | |
| del herbivore | |
| if herbivore.health <= 0: | |
| Animal.alive.remove(herbivore) | |
| del herbivore |
app/main.py
Outdated
Comment on lines
30
to
31
| not isinstance(herbivore, Carnivore) | ||
| and not herbivore.hidden |
There was a problem hiding this comment.
better to specify the class
Suggested change
| not isinstance(herbivore, Carnivore) | |
| and not herbivore.hidden | |
| isinstance(herbivore, Herbivore) | |
| and not herbivore.hidden |
Bohdan-Salamakha
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.