Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented py-herbivores-and-carnivores task #671

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 38 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,38 @@
# write your code here
class Animal:
alive = []

def __init__(
self,
name: str,
health: int = 100,
hidden: bool = False
) -> None:
self.health = health
self.name = name
self.hidden = hidden
Animal.alive.append(self)

def __repr__(self) -> str:
return (f"{{Name: {self.name}, Health: {self.health}, "
f"Hidden: {self.hidden}}}")


class Herbivore(Animal):

def hide(self) -> None:
self.hidden = not self.hidden


class Carnivore(Animal):

def bite(self, herbivore: Herbivore) -> None:
if (
not isinstance(herbivore, Carnivore)
and not herbivore.hidden
and self.health > 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to specify the class

Suggested change
not isinstance(herbivore, Carnivore)
and not herbivore.hidden
isinstance(herbivore, Herbivore)
and not herbivore.hidden

):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

animal with the health lower than zero will be automatically removed and the Carnivore will not be able to bite it

Suggested change
not isinstance(herbivore, Carnivore)
and not herbivore.hidden
and self.health > 0
not isinstance(herbivore, Carnivore)
and not herbivore.hidden

herbivore.health -= 50
if herbivore.health <= 0:
herbivore.health = 0
Animal.alive.remove(herbivore)
del herbivore
Loading