solution #683
solution #683
Conversation
app/main.py
Outdated
| class Carnivore(Animal): | ||
|
|
||
| @classmethod | ||
| def bite(cls, victim: "Herbivore") -> None: |
There was a problem hiding this comment.
If your method takes only Herbivore, then you wouldn't need the next check
Also no need to use quotes here
There was a problem hiding this comment.
Unfortunately without "if not isinstance(victim, Carnivore)" check I receive error "FAILED tests/test_main.py::test_carnivore_bite_carnivore - assert 50 == 100"
With this check code working fine
quotes I will remove for shoure
app/main.py
Outdated
| self.health = health | ||
| self.hidden = hidden | ||
|
|
||
| self.alive.append(self) |
There was a problem hiding this comment.
You should access class attribute through class name not self
|
|
||
| def __str__(self) -> str: | ||
|
|
||
| return (f"{{Name: {self.name}, " |
There was a problem hiding this comment.
if __repr__ is defined, and __str__ is not, the object will behave as though __str__=__repr__
So you can just change repr method here
There was a problem hiding this comment.
It is interesting. Thank you very much)
No description provided.