-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #683
base: master
Are you sure you want to change the base?
solution #683
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,38 @@ | ||
# write your code here | ||
class Animal: | ||
|
||
alive = [] | ||
|
||
def __init__(self, name: str, | ||
health: int = 100, | ||
hidden: bool = False) -> None: | ||
|
||
self.name = name | ||
self.health = health | ||
self.hidden = hidden | ||
|
||
self.alive.append(self) | ||
|
||
def __str__(self) -> str: | ||
|
||
return (f"{{Name: {self.name}, " | ||
f"Health: {self.health}, " | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is interesting. Thank you very much) |
||
f"Hidden: {self.hidden}}}") | ||
|
||
def __repr__(self) -> str: | ||
return self.__str__() | ||
|
||
|
||
class Herbivore(Animal): | ||
|
||
def hide(self) -> None: | ||
self.hidden = not self.hidden | ||
|
||
|
||
class Carnivore(Animal): | ||
|
||
@classmethod | ||
def bite(cls, victim: "Herbivore") -> None: | ||
if not isinstance(victim, Carnivore) and not victim.hidden: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If your method takes only Herbivore, then you wouldn't need the next check There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately without "if not isinstance(victim, Carnivore)" check I receive error "FAILED tests/test_main.py::test_carnivore_bite_carnivore - assert 50 == 100" |
||
victim.health -= 50 | ||
if victim.health <= 0: | ||
cls.alive.remove(victim) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should access class attribute through class name not self