Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #701

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

kostomeister
Copy link

No description provided.

Copy link

@Sel-Fisher Sel-Fisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, good idea with "die_animal" method

app/main.py Outdated
class Carnivore(Animal):

def bite(self, herbivore: Animal) -> None:
if isinstance(herbivore, Herbivore):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u can do it in one if statement

app/main.py Outdated
if not herbivore.hidden:
herbivore.health -= 50

if herbivore.health <= 0:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better move its statement inside in previous if

Copy link
Author

@kostomeister kostomeister Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean to move

if herbivore.health <= 0:
            herbivore.die_animal()

inside

        if isinstance(herbivore, Herbivore) and not herbivore.hidden:
           herbivore.health -= 50

Like that

        if isinstance(herbivore, Herbivore) and not herbivore.hidden:
           if herbivore.health <= 0:
               herbivore.die_animal()
           herbivore.health -= 50

Or not?

Copy link

@fsocie7y fsocie7y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, well done 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants