Animals Battle Royal #704
Animals Battle Royal #704
Conversation
app/main.py
Outdated
| target.health -= 50 | ||
| elif target.health <= 50: | ||
| target.health = 0 | ||
| Animal.alive.pop(Animal.alive.index(target)) |
There was a problem hiding this comment.
You can use just one "remove" method, that allows you to delete object from the list by itself, instead of using pop and index methods.
app/main.py
Outdated
| @staticmethod | ||
| def bite(target: Herbivore) -> None: | ||
| if not isinstance(target, Carnivore) and not target.hidden: | ||
| if target.health > 50: |
There was a problem hiding this comment.
I think it would be better to simply subtract 50 from "target.health" attribute, then check: if this attribute is less than or equal to zero and if so, delete it. Then your method will have only two conditions so the code will run faster and look cleaner.
app/main.py
Outdated
| if not isinstance(target, Carnivore) and not target.hidden: | ||
| if target.health > 50: | ||
| target.health -= 50 | ||
| elif target.health <= 50: |
There was a problem hiding this comment.
You can avoid using elif just with checking if health is nagative after bite.
app/main.py
Outdated
| return f"{{Name: {self.name}, " \ | ||
| f"Health: {self.health}, " \ | ||
| f"Hidden: {self.hidden}}}" |
There was a problem hiding this comment.
U can use brackets instead of linebreaker here
app/main.py
Outdated
| if not isinstance(target, Carnivore) and not target.hidden: | ||
| target.health -= 50 | ||
| if target.health <= 0: | ||
| Animal.alive.pop(Animal.alive.index(target)) |
app/main.py
Outdated
|
|
||
| class Carnivore(Animal): | ||
| @staticmethod | ||
| def bite(target: Herbivore) -> None: |
There was a problem hiding this comment.
fix type annotation for target
imho better annotation here is Animal
No description provided.