-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animals Battle Royal #704
base: master
Are you sure you want to change the base?
Animals Battle Royal #704
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,35 @@ | ||
# write your code here | ||
class Animal: | ||
|
||
alive = [] | ||
|
||
def __init__( | ||
self, | ||
name: str, | ||
health: int = 100, | ||
hidden: bool = False | ||
) -> None: | ||
self.name = name | ||
self.health = health | ||
self.hidden = hidden | ||
Animal.alive.append(self) | ||
|
||
def __repr__(self) -> str: | ||
return f"{{Name: {self.name}, " \ | ||
f"Health: {self.health}, " \ | ||
f"Hidden: {self.hidden}}}" | ||
|
||
|
||
class Herbivore(Animal): | ||
def hide(self) -> None: | ||
self.hidden = not self.hidden | ||
|
||
|
||
class Carnivore(Animal): | ||
@staticmethod | ||
def bite(target: Herbivore) -> None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fix type annotation for target |
||
if not isinstance(target, Carnivore) and not target.hidden: | ||
if target.health > 50: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be better to simply subtract 50 from "target.health" attribute, then check: if this attribute is less than or equal to zero and if so, delete it. Then your method will have only two conditions so the code will run faster and look cleaner. |
||
target.health -= 50 | ||
elif target.health <= 50: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can avoid using elif just with checking if health is nagative after bite. |
||
target.health = 0 | ||
Animal.alive.pop(Animal.alive.index(target)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can use just one "remove" method, that allows you to delete object from the list by itself, instead of using pop and index methods. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. better use Animal.alive.remove() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U can use brackets instead of linebreaker here