feat(sdk): Improve RoomEventCacheUpdate
#3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames `RoomEventCacheUpdate::UpdateReadMarker` to `ReadMarker`. The `Update` prefix is already part of the enum name.
…ve_to`. This patch renames `RoomEventCacheUpdate::ReadMarker::event_id` to `ReadMarker::move_to` as I feel like it conveys a better semantics.
This patch extracts `RoomEventCacheUpdate::Append::ambiguity_changes`
into a new variant `RoomEventCacheUpdate::Members { ambiguity_changes }
`.
This patch also creates a new private
`RoomEventCacheInner::send_grouped_updates_for_events` method to ensure
the updates are sent in a particular order.
This patch renames `RoomEventCacheUpdate::Append` to `SyncEvents`. The field `events` is renamed `timeline`. This patch also renames some variables to clarify the code and to match the renamings in `RoomEventCacheUpdate`.
bnjbvr
requested changes
May 27, 2024
This patch renames `ReadMarker { move_to: … }` to `MoveReaderMarkerTo
{ event_id: … }`.
This patch also renames `Members` to `UpdateMembers`.
Finally, this patch renames some other variables to avoid clashes with
terminology in `matrix_sdk_ui`.
This patch splits `RoomEventCacheUpdate::SyncEvents` into 2 new variants: `AddTimelineEvents` and `AddEphemeralEvents`. This patch takes this opportunity to update `matrix_sdk_ui::timeline` a little bit too. `handle_sync_events` is renamed `handle_ephemeral_events`, and the `SyncTimelineEvent` argument is removed: it's possible to use `add_events_at` directly to handle the `SyncTimelineEvent`s.
This patch prevents sending useless `RoomEventCacheUdpate` if their respective values are empty.
Hywan
force-pushed
the
feat-sdk-event-cache-use-linked-chunk-as-vector
branch
from
b5ccc54
to
3b1b893
Compare
bnjbvr
approved these changes
May 28, 2024
Signed-off-by: Benjamin Bouvier <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3471 +/- ##
==========================================
- Coverage 83.29% 83.29% -0.01%
==========================================
Files 248 248
Lines 25236 25245 +9
==========================================
+ Hits 21021 21028 +7
- Misses 4215 4217 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves/refactors
RoomEventCacheUpdatea little bit. That's preliminary work to supportVectorDifffrom theEventCacheinto theTimeline.EventCachestorage #3280