-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Improve RoomEventCacheUpdate
#3471
feat(sdk): Improve RoomEventCacheUpdate
#3471
Commits on May 27, 2024
-
chore(sdk): Rename
RoomEventCacheUpdate::UpdateReadMarker
.This patch renames `RoomEventCacheUpdate::UpdateReadMarker` to `ReadMarker`. The `Update` prefix is already part of the enum name.
Configuration menu - View commit details
-
Copy full SHA for dd44212 - Browse repository at this point
Copy the full SHA dd44212View commit details -
feat(sdk): Rename
RoomEventCacheUpdate::ReadMarker::event_id
to `mo……ve_to`. This patch renames `RoomEventCacheUpdate::ReadMarker::event_id` to `ReadMarker::move_to` as I feel like it conveys a better semantics.
Configuration menu - View commit details
-
Copy full SHA for 575d42b - Browse repository at this point
Copy the full SHA 575d42bView commit details -
feat(sdk): Extract
RoomEventCacheUpdate::Append::ambiguity_changes
.This patch extracts `RoomEventCacheUpdate::Append::ambiguity_changes` into a new variant `RoomEventCacheUpdate::Members { ambiguity_changes } `. This patch also creates a new private `RoomEventCacheInner::send_grouped_updates_for_events` method to ensure the updates are sent in a particular order.
Configuration menu - View commit details
-
Copy full SHA for ab102ae - Browse repository at this point
Copy the full SHA ab102aeView commit details -
feat(sdk): Rename
RoomEventCacheUpdate::Append
.This patch renames `RoomEventCacheUpdate::Append` to `SyncEvents`. The field `events` is renamed `timeline`. This patch also renames some variables to clarify the code and to match the renamings in `RoomEventCacheUpdate`.
Configuration menu - View commit details
-
Copy full SHA for 84c2c55 - Browse repository at this point
Copy the full SHA 84c2c55View commit details -
feat(sdk): Rename
RoomEventCacheUpdate::ReadMarker
andMembers
.This patch renames `ReadMarker { move_to: … }` to `MoveReaderMarkerTo { event_id: … }`. This patch also renames `Members` to `UpdateMembers`. Finally, this patch renames some other variables to avoid clashes with terminology in `matrix_sdk_ui`.
Configuration menu - View commit details
-
Copy full SHA for be22621 - Browse repository at this point
Copy the full SHA be22621View commit details -
feat(sdk): Split
RoomEventCacheUpdate::SyncEvents
.This patch splits `RoomEventCacheUpdate::SyncEvents` into 2 new variants: `AddTimelineEvents` and `AddEphemeralEvents`. This patch takes this opportunity to update `matrix_sdk_ui::timeline` a little bit too. `handle_sync_events` is renamed `handle_ephemeral_events`, and the `SyncTimelineEvent` argument is removed: it's possible to use `add_events_at` directly to handle the `SyncTimelineEvent`s.
Configuration menu - View commit details
-
Copy full SHA for 91f04a2 - Browse repository at this point
Copy the full SHA 91f04a2View commit details -
fix(sdk): Do not send
RoomEventCacheUpdate
if values are empty.This patch prevents sending useless `RoomEventCacheUdpate` if their respective values are empty.
Configuration menu - View commit details
-
Copy full SHA for c1805c9 - Browse repository at this point
Copy the full SHA c1805c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b1b893 - Browse repository at this point
Copy the full SHA 3b1b893View commit details
Commits on May 28, 2024
-
Apply suggestions from code review
Signed-off-by: Benjamin Bouvier <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c362412 - Browse repository at this point
Copy the full SHA c362412View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a2323d - Browse repository at this point
Copy the full SHA 3a2323dView commit details