Update Array based travel time data #1935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The travel time observer does not return the correct value for the travel time for the unused links. This difference is due to the discrete QSim time step. This fix incorporate the QSim config in the Travel Time data construction, such that the travel time for the unused link can be calculated more accurately.
|
Since a lot of other code is depending on this, it is probably not that easy to just fix it directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue #1933, the travel time observer does not return the correct value for the travel time for the unused links. This difference is due to the discrete QSim time step (see QSimFreeSpeedTravelTime vs FreeSpeedTravelTime). This fix incorporate the QSim config in the Travel Time data construction, such that the travel time for the unused link can be calculated more accurately.
In the future, we should also consider fixing the map based travel time data.