chore: renames era_test_node to anvil-zksync #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
force-pushed
the
db/rename-era-test-node-to-anvil-zksync
branch
from
1f200ec to
f383ea1
Compare
dutterbutter
added
the
do not merge 🛑
popzxc
reviewed
Nov 29, 2024
dutterbutter
force-pushed
the
db/rename-era-test-node-to-anvil-zksync
branch
2 times, most recently
from
d999ec9 to
4dff617
Compare
dutterbutter
added
needs review 👓
itegulov
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Looks good, just a few nits I have found.
We should also rename .github/assets/era_test_node_banner_{dark,light}.png and ideally the contents of the banner itself too (although not that easy so maybe we should remove the files altogether for now?).
There are some references to "zkSync Era In-Memory Node" left which should be renamed too (README.md, spec-tests/tests/lib.rs, src/lib.rs from what I have seen, could be more). Same for "Era Test Node" (many references).
dutterbutter
force-pushed
the
db/rename-era-test-node-to-anvil-zksync
branch
from
b30f44e to
bd48bb0
Compare
|
@itegulov went through again and updated. Please review at your convenience in preparation for tomorrows release 🙏 |
Romsters
approved these changes
Dec 3, 2024
itegulov
approved these changes
Dec 4, 2024
popzxc
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Related PRs:
Why ✋
Evidence 📷
Include screenshots, screen recordings, or
consoleoutput here demonstrating that your changes work as intended