-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include anvil-zksync in foundryup install script #765
Merged
dutterbutter
merged 13 commits into
main
from
db/update-install-script-to-include-anvil-zksync
Dec 10, 2024
Merged
feat: include anvil-zksync in foundryup install script #765
dutterbutter
merged 13 commits into
main
from
db/update-install-script-to-include-anvil-zksync
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
previously approved these changes
Dec 4, 2024
Karrq
reviewed
Dec 4, 2024
Karrq
reviewed
Dec 4, 2024
@dutterbutter is it time to hit the merge button? :) |
dutterbutter
added
needs review 👓
PR requires a review
and removed
do not merge 🛑
Do not merge this PR until label is removed
labels
Dec 9, 2024
@popzxc could you review please |
Romsters
approved these changes
Dec 10, 2024
popzxc
approved these changes
Dec 10, 2024
nbaztec
approved these changes
Dec 10, 2024
dutterbutter
deleted the
db/update-install-script-to-include-anvil-zksync
branch
December 10, 2024 14:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending release of: https://github.com/matter-labs/era-test-node/pull/444.
CI expected to fail until era_test_node renamed to
anvil-zksync
To test:
cd foundryup-zksync
./foundryup-zksync
What 💻
Why ✋
Evidence 📷
Include screenshots, screen recordings, or
console
output here demonstrating that your changes work as intended