test: refactor and actualise Transactions tests #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 67acbc6):
(expires Tue, 05 Mar 2024 13:21:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e508f9012944951194447cb8885950b451a24403 |
pcheremu
reviewed
Feb 27, 2024
| @@ -323,6 +522,37 @@ describe("Transactions", () => { | |||
| // expect(response.body).toStrictEqual(expect.objectContaining({ to: contract })) //unstable on CI | |||
There was a problem hiding this comment.
It probably can be uncommented
There was a problem hiding this comment.
Requested change added
pcheremu
reviewed
Feb 27, 2024
| @@ -323,6 +522,37 @@ describe("Transactions", () => { | |||
| // expect(response.body).toStrictEqual(expect.objectContaining({ to: contract })) //unstable on CI | |||
There was a problem hiding this comment.
Suggested change
| // expect(response.body).toStrictEqual(expect.objectContaining({ to: contract })) //unstable on CI | |
| expect(response.body).toStrictEqual(expect.objectContaining({ to: contract })); |
There was a problem hiding this comment.
Requested change added
pcheremu
reviewed
Feb 27, 2024
Reverting commented step
pcheremu
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Added coverage for all 0 items in responses for Transaction endpoints
Why ❔
Checklist