-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Minor extensions for server interoperability #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need this? Perhaps we can make it just easier to generate well-signed blocks?
I thought that was the approach we agreed upon. For tests / initial PoC it would be easy to generate well-signed blocks, but for production, we'd need to introduce key management and reliably broadcast information about the validator set (I guess using L1 smart contracts). @brunoffranca WDYT? |
Hey, if you guys think it's easier to introduce well-signed blocks now, then it's fine by me. It seemed simpler to me at the time to just turn off QC validation. But at the time I also thought we were not going to be running the consensus actor at all. |
3be8165
to
147cae6
Compare
147cae6
to
a0905d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remember to address "block_hash:" -> "block_header_hash:"
What ❔
BlockHeaderHash
.SyncBlocks
actor terminate successfully on context cancellation.Why ❔
Part of preparations for the integration with the server codebase.