Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Minor extensions for server interoperability #21

Merged
merged 10 commits into from
Nov 7, 2023

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 31, 2023

What ❔

  • Simplifies generating executor configurations.
  • Adds byte conversions for BlockHeaderHash.
  • Makes SyncBlocks actor terminate successfully on context cancellation.

Why ❔

Part of preparations for the integration with the server codebase.

@slowli slowli marked this pull request as ready for review October 31, 2023 16:26
Copy link
Collaborator

@pompon0 pompon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need this? Perhaps we can make it just easier to generate well-signed blocks?

@slowli
Copy link
Contributor Author

slowli commented Nov 2, 2023

Are you sure we need this? Perhaps we can make it just easier to generate well-signed blocks?

I thought that was the approach we agreed upon. For tests / initial PoC it would be easy to generate well-signed blocks, but for production, we'd need to introduce key management and reliably broadcast information about the validator set (I guess using L1 smart contracts). @brunoffranca WDYT?

@brunoffranca
Copy link
Member

Hey, if you guys think it's easier to introduce well-signed blocks now, then it's fine by me. It seemed simpler to me at the time to just turn off QC validation. But at the time I also thought we were not going to be running the consensus actor at all.

@slowli slowli force-pushed the aov-bft-366-allow-switching-off-qc-validation branch 2 times, most recently from 3be8165 to 147cae6 Compare November 2, 2023 14:24
@slowli slowli force-pushed the aov-bft-366-allow-switching-off-qc-validation branch from 147cae6 to a0905d4 Compare November 3, 2023 11:24
@slowli slowli changed the title feat: Allow switching off QC validation feat: Minor extensions for server interoperability Nov 3, 2023
@slowli slowli requested a review from pompon0 November 3, 2023 12:03
pompon0
pompon0 previously approved these changes Nov 6, 2023
Copy link
Collaborator

@pompon0 pompon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remember to address "block_hash:" -> "block_header_hash:"

pompon0
pompon0 previously approved these changes Nov 6, 2023
@slowli slowli merged commit aaa1093 into main Nov 7, 2023
4 checks passed
@slowli slowli deleted the aov-bft-366-allow-switching-off-qc-validation branch November 7, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants