feat: Minor extensions for server interoperability

node/Cargo.toml

@@ -31,10 +31,8 @@ ark-ec = "0.4.2"
 ark-serialize = { version = "0.4.2", features = ["std"] }
 num-traits = "0.2.17"
 clap = { version = "4.3.3", features = ["derive"] }
-ed25519-dalek = { version = "2.0.0", features = ["serde", "rand_core"] }
-futures = "0.3.28"
+ed25519-dalek = { version = "2.0.0", features = ["rand_core"] }
 hex = "0.4.3"
-hyper = { version = "0.14.27", features = ["http1", "http2", "server", "tcp"] }
 im = "15.1.0"
 once_cell = "1.17.1"
 pin-project = "1.1.0"

node/actors/executor/Cargo.toml

@@ -8,6 +8,7 @@ license.workspace = true
 
 [dependencies]
 anyhow.workspace = true
+rand.workspace = true
 tracing.workspace = true
 vise.workspace = true
 
@@ -23,5 +24,4 @@ network = { path = "../network" }
 sync_blocks = { path = "../sync_blocks" }
 
 [dev-dependencies]
-rand.workspace = true
 tokio.workspace = true

node/actors/executor/src/lib.rs

@@ -13,6 +13,7 @@ use utils::pipe;
 mod config;
 mod io;
 mod metrics;
+pub mod testonly;
 #[cfg(test)]
 mod tests;
 

node/actors/executor/src/testonly.rs

@@ -0,0 +1,99 @@
+//! Testing extensions for node executor.
+
+use crate::config::{ConsensusConfig, ExecutorConfig, GossipConfig};
+use concurrency::net;
+use consensus::testonly::make_genesis;
+use network::testonly::Instance;
+use rand::Rng;
+use roles::{
+    node,
+    validator::{self, Payload},
+};
+use std::collections::HashMap;
+
+/// Full validator configuration.
+#[derive(Debug)]
+#[non_exhaustive]
+pub struct FullValidatorConfig {
+    /// Executor configuration.
+    pub node_config: ExecutorConfig,
+    /// Secret key of the node used for identification in the gossip network.
+    pub node_key: node::SecretKey,
+    /// Consensus configuration of the validator.
+    pub consensus_config: ConsensusConfig,
+    /// Secret key for consensus.
+    pub validator_key: validator::SecretKey,
+}
+
+impl FullValidatorConfig {
+    /// Generates a validator config for a network with a single validator.
+    pub fn for_single_validator(rng: &mut impl Rng, genesis_block_payload: Payload) -> Self {
+        let mut net_configs = Instance::new_configs(rng, 1, 0);
+        assert_eq!(net_configs.len(), 1);
+        let net_config = net_configs.pop().unwrap();
+        let consensus_config = net_config.consensus.unwrap();
+        let validator_key = consensus_config.key.clone();
+        let consensus_config = ConsensusConfig::from(consensus_config);
+
+        let (genesis_block, validators) =
+            make_genesis(&[validator_key.clone()], genesis_block_payload);
+        let node_key = net_config.gossip.key.clone();
+        let node_config = ExecutorConfig {
+            server_addr: *net_config.server_addr,
+            gossip: net_config.gossip.into(),
+            genesis_block,
+            validators,
+        };
+
+        Self {
+            node_config,
+            node_key,
+            consensus_config,
+            validator_key,
+        }
+    }
+
+    /// Creates a new external node and configures this validator to accept incoming connections from it.
+    pub fn connect_external_node(&mut self, rng: &mut impl Rng) -> ExternalNodeConfig {
+        let external_node_config = ExternalNodeConfig::new(rng, self);
+        self.node_config
+            .gossip
+            .static_inbound
+            .insert(external_node_config.node_key.public());
+        external_node_config
+    }
+}
+
+/// Configuration for an external node (i.e., non-validator node).
+#[derive(Debug)]
+#[non_exhaustive]
+pub struct ExternalNodeConfig {
+    /// Executor configuration.
+    pub node_config: ExecutorConfig,
+    /// Secret key of the node used for identification in the gossip network.
+    pub node_key: node::SecretKey,
+}
+
+impl ExternalNodeConfig {
+    fn new(rng: &mut impl Rng, validator: &FullValidatorConfig) -> Self {
+        let node_key: node::SecretKey = rng.gen();
+        let external_node_addr = net::tcp::testonly::reserve_listener();
+        let node_config = ExecutorConfig {
+            server_addr: *external_node_addr,
+            gossip: GossipConfig {
+                key: node_key.public(),
+                static_outbound: HashMap::from([(
+                    validator.node_key.public(),
+                    validator.node_config.server_addr,
+                )]),
+                ..validator.node_config.gossip.clone()
+            },
+            ..validator.node_config.clone()
+        };
+
+        Self {
+            node_config,
+            node_key,
+        }
+    }
+}

node/actors/executor/src/tests.rs

@@ -1,12 +1,9 @@
 //! High-level tests for `Executor`.
 
 use super::*;
+use crate::testonly::FullValidatorConfig;
 use concurrency::sync;
-use consensus::testonly::make_genesis;
-use network::testonly::Instance;
-use rand::Rng;
 use roles::validator::{BlockNumber, Payload};
-use std::collections::HashMap;
 use storage::{BlockStore, InMemoryStorage, StorageError};
 
 async fn run_executor(ctx: &ctx::Ctx, executor: Executor<InMemoryStorage>) -> anyhow::Result<()> {
@@ -37,40 +34,7 @@ async fn store_final_blocks(
     Ok(())
 }
 
-#[derive(Debug)]
-struct FullValidatorConfig {
-    node_config: ExecutorConfig,
-    node_key: node::SecretKey,
-    consensus_config: ConsensusConfig,
-    validator_key: validator::SecretKey,
-}
-
 impl FullValidatorConfig {
-    fn for_single_validator(rng: &mut impl Rng) -> Self {
-        let mut net_configs = Instance::new_configs(rng, 1, 0);
-        assert_eq!(net_configs.len(), 1);
-        let net_config = net_configs.pop().unwrap();
-        let consensus_config = net_config.consensus.unwrap();
-        let validator_key = consensus_config.key.clone();
-        let consensus_config = ConsensusConfig::from(consensus_config);
-
-        let (genesis_block, validators) = make_genesis(&[validator_key.clone()], Payload(vec![]));
-        let node_key = net_config.gossip.key.clone();
-        let node_config = ExecutorConfig {
-            server_addr: *net_config.server_addr,
-            gossip: net_config.gossip.into(),
-            genesis_block,
-            validators,
-        };
-
-        Self {
-            node_config,
-            node_key,
-            consensus_config,
-            validator_key,
-        }
-    }
-
     fn into_executor(
         self,
         storage: Arc<InMemoryStorage>,
@@ -98,7 +62,7 @@ async fn executing_single_validator() {
     let ctx = &ctx::root();
     let rng = &mut ctx.rng();
 
-    let validator = FullValidatorConfig::for_single_validator(rng);
+    let validator = FullValidatorConfig::for_single_validator(rng, Payload(vec![]));
     let genesis_block = &validator.node_config.genesis_block;
     let storage = InMemoryStorage::new(genesis_block.clone());
     let storage = Arc::new(storage);
@@ -126,28 +90,8 @@ async fn executing_validator_and_external_node() {
     let ctx = &ctx::test_root(&ctx::AffineClock::new(20.0));
     let rng = &mut ctx.rng();
 
-    let mut validator = FullValidatorConfig::for_single_validator(rng);
-
-    let external_node_key: node::SecretKey = rng.gen();
-    let external_node_addr = net::tcp::testonly::reserve_listener();
-    let external_node_config = ExecutorConfig {
-        server_addr: *external_node_addr,
-        gossip: GossipConfig {
-            key: external_node_key.public(),
-            static_outbound: HashMap::from([(
-                validator.node_key.public(),
-                validator.node_config.server_addr,
-            )]),
-            ..validator.node_config.gossip.clone()
-        },
-        ..validator.node_config.clone()
-    };
-
-    validator
-        .node_config
-        .gossip
-        .static_inbound
-        .insert(external_node_key.public());
+    let mut validator = FullValidatorConfig::for_single_validator(rng, Payload(vec![]));
+    let external_node = validator.connect_external_node(rng);
 
     let genesis_block = &validator.node_config.genesis_block;
     let validator_storage = InMemoryStorage::new(genesis_block.clone());
@@ -158,8 +102,8 @@ async fn executing_validator_and_external_node() {
 
     let (validator, blocks_receiver) = validator.into_executor(validator_storage.clone());
     let external_node = Executor::new(
-        external_node_config,
-        external_node_key,
+        external_node.node_config,
+        external_node.node_key,
         external_node_storage.clone(),
     )
     .unwrap();

node/actors/network/Cargo.toml

@@ -25,7 +25,6 @@ schema = { path = "../../libs/schema" }
 utils = { path = "../../libs/utils" }
 
 [dev-dependencies]
-futures.workspace = true
 pretty_assertions.workspace = true
 test-casing.workspace = true
 tokio.workspace = true

node/actors/network/src/consensus/tests.rs

@@ -16,12 +16,12 @@ async fn test_one_connection_per_validator() {
     let mut nodes = testonly::Instance::new(rng, 3, 1);
 
     scope::run!(ctx, |ctx,s| async {
-        for (i,n) in nodes.iter().enumerate() {
+        for (i, node) in nodes.iter().enumerate() {
             let (network_pipe, _) = pipe::new();
 
             s.spawn_bg(run_network(
                 ctx,
-                n.state.clone(),
+                node.state.clone(),
                 network_pipe
             ).instrument(tracing::info_span!("node", i)));
         }