Joystick:cc: Fix gimbal rate behaviour after commit e38fd4da1b4e54ec1… #12359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested the implementation with a PS4 controller and a physical gimbal device, and I can confirm that the issue has been resolved. The gimbal now stops rotating as expected when a button of the respective direction is released. |
|
Nice catch, sorry about that |
|
@HTRamsey no need to be sorry, you did a great and needed rework. I was just pinging you for awareness. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the refactor done on this commit e38fd4d we stopped sending the stop commands to gimbal control when releasing joystick buttons, so the functionality was totally broken.
For awareness @HTRamsey